Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 833 timeline context #1394

Merged
merged 34 commits into from
May 12, 2024

Conversation

BapBap7
Copy link
Contributor

@BapBap7 BapBap7 commented Apr 22, 2024

dev

JIRA

Code reviewers

  • @github_username

Second Level Review

  • @github_username

Summary of issue

ToDo

Summary of change

ToDo

Testing approach

ToDo

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

@BapBap7 BapBap7 changed the base branch from develop to release/1.0.0 April 27, 2024 09:32
@BapBap7 BapBap7 marked this pull request as ready for review May 2, 2024 09:09
@@ -1,6 +1,6 @@
{
"ConnectionStrings": {
"DefaultConnection": "Server=127.0.0.1;Database=StreetcodeDb;User Id=sa;Password=Admin@1234;MultipleActiveResultSets=true"
"DefaultConnection": "Server=PC;Database=Streetcode1;MultipleActiveResultSets=True;TrustServerCertificate=true;Trusted_Connection=true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

U need to change this back to:
"DefaultConnection": "Server=127.0.0.1;Database=StreetcodeDb;User Id=sa;Password=Admin@1234;MultipleActiveResultSets=true"

Copy link

sonarcloud bot commented May 12, 2024

@vasylashka vasylashka merged commit 4c9068a into release/1.0.0 May 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants